-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 apis: fix missing categories marker for VShpereVM in v1alpha3 and v1alpha4 #1973
Conversation
Note: on main this is reproducible using the following script:
Example failure:
|
Should be fine to fix it this way, given that there is only one categories field per CRD. Would be good to have a controller-tools issue for it though (just to report it) /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: randomvariable The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I would cherry-pick this to all supported branches /cherry-pick release-1.7 |
/cherry-pick release-1.6 |
/cherry-pick release-1.5 |
@sbueringer: new pull request created: #1990 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sbueringer: new pull request created: #1991 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sbueringer: new pull request created: #1992 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Adds the missing
categories=cluster-api
marker to:apis/v1alpha3/vspherevm_types.go
apis/v1alpha4/vspherevm_types.go
The missing markers result into inconsistent results for the generated CRD's.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Related to #1928
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: